[math] Support multithreaded fits of TGraphErrors with x errors#22651
Merged
Conversation
Test Results 22 files 22 suites 3d 16h 53m 8s ⏱️ For more details on these failures, see this check. Results for commit 9103e6f. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
Jun 19, 2026
dpiparo
left a comment
dpiparo
left a comment
Member
There was a problem hiding this comment.
lgtm. If time allows, perhaps a second look to the comments could be of help.
Make FitUtil::EvaluateChi2Effective execution-policy aware via TThreadExecutor (same pattern as EvaluateChi2) and thread the policy through Chi2FCN. Point coordinates/errors are read via the thread-safe component accessors, since GetPoint/GetPointError use shared temp buffers. Also honour the SERIAL/MULTITHREAD options for graph fits. Adds exec-policy tests to testFitter. Closes root-project#10021. 🤖 Done with the help of AI.
lmoneta
approved these changes
Jun 19, 2026
lmoneta
left a comment
lmoneta
left a comment
Member
There was a problem hiding this comment.
LGTM!
Thanks Jonas (and Claude) for adding this support completing the fitting multi-thread support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make FitUtil::EvaluateChi2Effective execution-policy aware via TThreadExecutor (same pattern as EvaluateChi2) and thread the policy through Chi2FCN. Point coordinates/errors are read via the thread-safe component accessors, since GetPoint/GetPointError use shared temp buffers. Also honour the SERIAL/MULTITHREAD options for graph fits. Adds exec-policy tests to testFitter.
Closes #10021.
🤖 Done with the help of AI.